Skip to content

Changeling voice mimicry#43675

Open
ketufaispikinut wants to merge 29 commits intospace-wizards:masterfrom
ketufaispikinut:ling_voice
Open

Changeling voice mimicry#43675
ketufaispikinut wants to merge 29 commits intospace-wizards:masterfrom
ketufaispikinut:ling_voice

Conversation

@ketufaispikinut
Copy link
Copy Markdown
Contributor

About the PR

Gives a buyable voice mask ability to the changeling. When bought it starts disabled (as to not immediately run first-time changeling's runs). Unlike the normal voice mask, it only overrides your voice (shift+clicking reveals you and currently makes you unambiguously a changeling if you don't have anything that could mask your identity).

I made the texture.
Capture d’écran, le 2026-04-21 à 08 32 03

Why / Balance

Working towards #39439

Technical details

Gave an IsInnate field to the VoiceMaskComponent and made it not work as an implant but as an innate ability when this field is set to true. Besides that it's just yaml changes. The VoiceMaskComponent also gets a new TitleText that allows it to set the name of its UI window.

Media

Capture d’écran, le 2026-04-21 à 08 16 42 Capture d’écran, le 2026-04-21 à 08 16 24 (Note that the UI's title is now set to a more fitting "Voice Mimicry". This does not affect the normal UI, tough.)

Requirements

Breaking changes

None.

Changelog

Not player facing :(

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: UI Changes: Might require knowledge of UI design or code. size/M Denotes a PR that changes 100-999 lines. labels Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

RSI Diff Bot; head commit 2b56929 merging into 63b6923
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Actions/changeling2.rsi

State Old New Status
mimicry Added

Edit: diff updated after 2b56929

Copy link
Copy Markdown
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woe a fuckton of newlines upon ye

Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Shared/VoiceMask/VoiceMaskComponent.cs Outdated
Comment thread Resources/Locale/en-US/store/changeling-catalog.ftl Outdated
Comment thread Resources/Prototypes/Actions/changeling.yml Outdated
Comment thread Resources/Prototypes/Entities/Mobs/Player/changeling.yml
Comment thread Resources/Textures/Interface/Actions/changeling2.rsi/meta.json Outdated
@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Apr 21, 2026
ketufaispikinut and others added 9 commits April 21, 2026 09:01
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
oh god you can just do batches oh my god

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@ThanosDeGraf ThanosDeGraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so lonely... please help me...

Sickass feature! Nice work also in expanding the voice changer Ui so the title changes to Voice Mimicry, remaining in-theme.

Tested this out in-game, all the toggles work as expected and do start out as Off when buying the ability. Just some small nitpicks but otherwise LGTM

Comment thread Content.Server/Store/Systems/StoreSystem.Ui.cs
Comment thread Content.Server/Store/Systems/StoreSystem.Ui.cs
@ThanosDeGraf
Copy link
Copy Markdown
Contributor

oh hi there @ScarKy0 <3 o/

Comment thread Content.Client/VoiceMask/VoiceMaskNameChangeWindow.xaml.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Shared/VoiceMask/VoiceMaskComponent.cs
Comment thread Resources/Prototypes/Catalog/changeling_catalog.yml Outdated
Comment thread Resources/Prototypes/Entities/Mobs/Player/changeling.yml
@ScarKy0 ScarKy0 added this pull request to the merge queue Apr 21, 2026
@ScarKy0 ScarKy0 removed this pull request from the merge queue due to a manual request Apr 21, 2026
Copy link
Copy Markdown
Member

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesss so cool!

Comment thread Content.Shared/VoiceMask/VoiceMaskComponent.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Apr 22, 2026
Copy link
Copy Markdown
Member

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style issues

Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Shared/VoiceMask/VoiceMaskComponent.cs
Comment thread Resources/Locale/en-US/changeling/changeling.ftl Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Apr 23, 2026
@Pok27 Pok27 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. P3: Standard Priority: Default priority for repository items. labels Apr 23, 2026
@ketufaispikinut
Copy link
Copy Markdown
Contributor Author

There we go, reverted the text changes to only the title, added newlines, removed comments, changed comments, indented things. Fixed lies!

Copy link
Copy Markdown
Member

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun!!

@beck-thompson beck-thompson removed the S: Awaiting Changes Status: Changes are required before another review can happen label Apr 23, 2026
Copy link
Copy Markdown
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i HATE changleings i HATE antagonists i HATE our players because they LOVE changelins and i HATE changelings

@Emisse Emisse added the S: Art Approval Status: The art (e.g. Spritework) has been approved by an art lead. label Apr 23, 2026
nomdéraisonnablementlong added 2 commits April 25, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: UI Changes: Might require knowledge of UI design or code. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Art Approval Status: The art (e.g. Spritework) has been approved by an art lead. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants